Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid repository URLs in 'Elyra in an air gapped environment' topic #2810

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

ptitzler
Copy link
Member

In version 3.9.0rc0 some URLs in the Running Elyra in an air gapped environment topic were corrupted by the release script. This PR fixes the problems.

What changes were proposed in this pull request?

s/v3.9.0rc0/main/g

How was this pull request tested?

  • Reviewed the output of make docs
    image

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:bug Something isn't working area:documentation Improvements or additions to documentation labels Jun 28, 2022
@ptitzler ptitzler added this to the 3.10.0 milestone Jun 28, 2022
@elyra-bot
Copy link

elyra-bot bot commented Jun 28, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptitzler you need to remove the final / from first URL as it will throw a 400 - invalid request

image

@ptitzler ptitzler requested a review from lresende June 29, 2022 12:54
@ptitzler
Copy link
Member Author

@ptitzler you need to remove the final / from first URL as it will throw a 400 - invalid request

Oops. Thank you. Fixed!

@lresende lresende merged commit 75a2c92 into elyra-ai:main Jun 29, 2022
@ptitzler ptitzler deleted the release-restore-bug branch July 7, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants