-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev workflow documentation updates #2832
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This will be good to have back in the docs to streamline future installations. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great. I'm wondering, though, if we could add one more thing that just came up in this discussion? If not, no big deal - it could be tackled another time.
I think this would amount to:
- adding a link to
GNU Make
to the Requirements section. - adding installation instructions - which would probably be best to just defer to the previously linked web page for their platform.
- adding a verification step to run
make
from the github directory (and reference the output that is a couple sections below in Build & Installation
Sounds fair, |
@salonee13 - you're probably busy making changes to the community repository. Let us know if you are unable to get to this before semester end and we can merge as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thank you for adding the information regarding make
. I had a small comment regarding the time and location in which the make
installation is verified.
Co-authored-by: Kevin Bates <kbates4@gmail.com>
What changes were proposed in this pull request?
Added lines to documentation to have the contributor check to see if they have yarn and node installed correctly.
How was this pull request tested?
Reviewed the page after make docs
Developer's Certificate of Origin 1.1