Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Data Hub image refresh instructions #2847

Merged
merged 5 commits into from
Jul 25, 2022

Conversation

ptitzler
Copy link
Member

image

Closes #2844

What changes were proposed in this pull request?

Adds a new topic to the developer guide that outlines how we update the Open Data Hub Elyra image stream.

How was this pull request tested?

  • Review output of make docs

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Jul 21, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler marked this pull request as draft July 21, 2022 18:04
@ptitzler ptitzler added area:documentation Improvements or additions to documentation component:build build and build related issues(dependencies and docker) platform: Open Data Hub labels Jul 21, 2022
@ptitzler ptitzler added this to the 3.11.0 milestone Jul 21, 2022
@ptitzler ptitzler marked this pull request as ready for review July 21, 2022 21:03
Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small typo below. Also, it's slightly unclear to me when a version change to the base container image is required, but that could be my ignorance and not a fault of the PR 🙂

Other than that, everything make sense and is working for me!

docs/source/developer_guide/refresh-elyra-on-odh.md Outdated Show resolved Hide resolved
@shalberd
Copy link
Contributor

Very nice, thank you.

@ptitzler
Copy link
Member Author

Your changes look good. We should be ready to merge once Kiersten has approved the new additions.

@akchinSTC akchinSTC merged commit 735c68a into elyra-ai:main Jul 25, 2022
@ptitzler ptitzler deleted the update-elyra-in-odh branch July 25, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation component:build build and build related issues(dependencies and docker) platform: Open Data Hub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how we publish Elyra container images for Open Data Hub
4 participants