Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid URL in extension descriptions #2860

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

ptitzler
Copy link
Member

The following Elyra stand-alone extension pages on PyPI contain a documentation link, which is an invalid URL:

image

The issue is caused by the release script https://github.com/elyra-ai/elyra/blob/main/create-release.py#L579-L611, which uses https://elyra.readthedocs.io/en/{config.new_version}/ as base URL instead of https://elyra.readthedocs.io/en/v{config.new_version}/

What changes were proposed in this pull request?

See above.

How was this pull request tested?

Manually confirmed that the new URL is valid.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:bug Something isn't working component:build build and build related issues(dependencies and docker) labels Jul 28, 2022
@ptitzler ptitzler added this to the 3.11.0 milestone Jul 28, 2022
@elyra-bot
Copy link

elyra-bot bot commented Jul 28, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler changed the title Fix extension descriptions Fix invalid URL in extension descriptions Jul 28, 2022
@ptitzler ptitzler mentioned this pull request Jul 28, 2022
@akchinSTC akchinSTC merged commit 228e39e into elyra-ai:main Jul 29, 2022
@ptitzler ptitzler deleted the fix-extension-descriptions branch July 29, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker) kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants