-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kubernetes annotations #2868
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ptitzler - this will be extremely useful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my scenarios are testing as expected!
(Also, 20 files changed, wow! Hoping to reduce that for future params with some upcoming re-factoring 🤞 )
This PR adds support for Kubernetes annotations for Kubeflow Pipelines and Apache Airflow runtime environments.
Annotations are supported for generic components and custom components and can be defined as pipeline defaults or for individual nodes.
Input needs to be entered as a string using the
annotation_key=annotation_value
format until proper UI support (#2780) is released.Annotation keys are validated according to this spec.
Closes #2849
Pipeline default settings in VPE
Displayed in section "Node defaults" (Settings in this section apply to all nodes):
Generic node setting in VPE
Custom node setting in VPE
Displayed in section "Additional properties"
Applied annotations (KFP)
Example
describe pod
output (KFP)Applied annotations (Airflow)
The applied annotations can be inspected using the
kubectl describe pod
command or in the DAG task instance details page in the Airflow UI:Notes:
What changes were proposed in this pull request?
user_guide/pipelines.html
documentationHow was this pull request tested?
make docs
Developer's Certificate of Origin 1.1