-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 'file' URI scheme to URL-based connectors #2873
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Is it possible to add a test or two for this? Are there any doc adjustments necessary?
Done! I've added server tests for the connectors and the new utility library. I've also updated the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Super valuable for the Airflow packages - I noticed a big difference in load time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the minor doc updates/suggestions, this looks great. Transport adapters are very cool!
Co-authored-by: Kiersten Stokes <kierstenstokes@gmail.com>
Co-authored-by: Kiersten Stokes <kierstenstokes@gmail.com>
Closes #2872
What changes were proposed in this pull request?
The built-in URL catalog connector, Apache Airflow package connector, and the Apache Airflow provider package connectors now support input of a URL that uses the
file
URI scheme in addition to the already supportedHTTP
andHTTPS
schemes. No changes to the UI or validation are required.The behavior is as follows:
file://path/to/file
) -> HTTP status code 200file://i/am/a/dir
) -> HTTP status code 400 (invalid input)file://no/such/file
) -> HTTP status code 404 (not found)file://path/to/file
) just like it is done for the filesystem connector when bo base directory is specified.How was this pull request tested?
make docs
(user_guide/pipeline-components.html
)file://absolute/path/to/file.whl
URLfile://absolute/path/to/no-such-file.whl
URL (specifying a file that does not exist)file://absolute/path/to/dir
URL (specifying an existing directory)file://absolute/path/to/file.whl
URLfile://absolute/path/to/no-such-file.whl
URL (specifying a file that does not exist)file://absolute/path/to/dir
URL (specifying an existing directory)file://absolute/path/to/file.whl
URLfile://absolute/path/to/no-such-file.whl
URL (specifying a file that does not exist)file://absolute/path/to/dir
URL (specifying an existing directory)Developer's Certificate of Origin 1.1