Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address SVG rendering issues #2895

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Address SVG rendering issues #2895

merged 1 commit into from
Aug 22, 2022

Conversation

ajbozarth
Copy link
Member

As found by @ptitzler in the screen shot below the svgs wasn't rendering correctly. I solved this by cleaning up the svg file.

image

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ajbozarth ajbozarth added this to the 3.11.0 milestone Aug 22, 2022
@ajbozarth ajbozarth self-assigned this Aug 22, 2022
@elyra-bot
Copy link

elyra-bot bot commented Aug 22, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed, icon is back and appears as it should.
image

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptitzler ptitzler added kind:bug Something isn't working component:metadata-editor Metadata Editor Extension labels Aug 22, 2022
@akchinSTC akchinSTC merged commit 3936558 into elyra-ai:main Aug 22, 2022
@ajbozarth ajbozarth deleted the iconId branch August 22, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:metadata-editor Metadata Editor Extension kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants