Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python icon to match JupyterLab #2917

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Conversation

ajbozarth
Copy link
Member

@ajbozarth ajbozarth commented Sep 2, 2022

In jupyterlab/jupyterlab#13035 JupyterLab has updated their python svg to meet the requirements of the PSF Trademark Committee. Though the svg in that PR is very similar to the one Elyra uses, it does have some differences. As such we should switch to using the new icon.

For now I've simply updated our svgs to match the new icon, but once that PR is released (It will be in the next 3.X release, timing unknown) we will want to remove our front end svg and replace all references to it with the jupyterlab LabIcon

I've removed our python LabIcon and updated references to it to use the icon from core. I've also updated the icon served by our backend to use the new svg file as well.

For reference: The updated icon has the correct colors (the Elyra one has a slightly dark shade of yellow) and margins to match other icons in lab

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Due to trademark concerns, JupyterLab has updated thier python
icon. This change will be out in the next release.
@ajbozarth ajbozarth self-assigned this Sep 2, 2022
@elyra-bot
Copy link

elyra-bot bot commented Sep 2, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC akchinSTC self-requested a review September 6, 2022 15:33
@akchinSTC akchinSTC added this to the 3.12.0 milestone Sep 6, 2022
@ajbozarth
Copy link
Member Author

v3.4.6 has been released, so I will be updating this as stated above

@ajbozarth ajbozarth added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Sep 7, 2022
@ajbozarth
Copy link
Member Author

I've pushed the updates, this is ready for review now. Screenshot below:
Screen Shot 2022-09-07 at 1 47 20 PM

@ptitzler if you could take a look at this and feel free to push any doc screen shot changes as needed.

@ajbozarth ajbozarth removed the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Sep 7, 2022
@ptitzler
Copy link
Member

ptitzler commented Sep 9, 2022

The icon colors look different but I expected them to be the same

image

@ajbozarth
Copy link
Member Author

The icon colors look different but I expected them to be the same

Kernels supply their own icon in the form of an encoded png, in this case they are using the official logo which has an opacity gradient. So the SVG file removes the gradient and sets it to the base color, this change/difference was approved by both the PSF Trademark Committee and the core lab devs.

Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ptitzler
Copy link
Member

Looks like you've missed one version bump in https://github.com/ajbozarth/elyra/blob/py_icon/etc/docker/elyra_development/requirements.yml#L5

@ptitzler ptitzler merged commit 5043159 into elyra-ai:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants