-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python icon to match JupyterLab #2917
Conversation
Due to trademark concerns, JupyterLab has updated thier python icon. This change will be out in the next release.
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
v3.4.6 has been released, so I will be updating this as stated above |
I've pushed the updates, this is ready for review now. Screenshot below: @ptitzler if you could take a look at this and feel free to push any doc screen shot changes as needed. |
Kernels supply their own icon in the form of an encoded png, in this case they are using the official logo which has an opacity gradient. So the SVG file removes the gradient and sets it to the base color, this change/difference was approved by both the PSF Trademark Committee and the core lab devs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like you've missed one version bump in https://github.com/ajbozarth/elyra/blob/py_icon/etc/docker/elyra_development/requirements.yml#L5 |
In jupyterlab/jupyterlab#13035 JupyterLab has updated their python svg to meet the requirements of the PSF Trademark Committee. Though the svg in that PR is very similar to the one Elyra uses, it does have some differences. As such we should switch to using the new icon.
For now I've simply updated our svgs to match the new icon, but once that PR is released (It will be in the next 3.X release, timing unknown) we will want to remove our front end svg and replace all references to it with the jupyterlab LabIconI've removed our python LabIcon and updated references to it to use the icon from core. I've also updated the icon served by our backend to use the new svg file as well.
For reference: The updated icon has the correct colors (the Elyra one has a slightly dark shade of yellow) and margins to match other icons in lab
Developer's Certificate of Origin 1.1