Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline editor: Allow for configuration of labels #2943

Merged
merged 6 commits into from
Oct 2, 2022

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Sep 28, 2022

Extend the pipeline editor to allow for adding of kubernetes labels in generic and custom components. A pipeline default can be configured in the pipeline properties. Support is implemented for Kubeflow Pipelines and Apache Airflow.

image

The key/value pair can be used to query Kubernetes resources:

$ kubectl get pods -n kubeflow-user-example-com -l project=demo
NAME                     READY   STATUS      RESTARTS   AGE
lambda-vh2zp-982439046   0/2     Completed   0          38s

The pipelines documentation describes the new property:

image

Closes #2941

What changes were proposed in this pull request?

  • See above

How was this pull request tested?

  • reviewed the output of make docs
  • Added validation tests (for valid and invalid inputs)
  • Updated handlers test
  • Updated integration tests

pipeline defaults:

  • no label key specified
  • no label value specified
  • invalid label key specified
  • valid key/value

generic nodes (kfp):

  • no label key specified
  • no label value specified
  • invalid label key specified
  • valid key/value

custom nodes (kfp):

  • no label key specified
  • no label value specified
  • invalid label key specified
  • valid key/value

generic nodes (airflow):

  • no label key specified
  • no label value specified
  • invalid label key specified
  • valid key/value

custom nodes (airflow):

  • no label key specified
  • no label value specified
  • invalid label key specified
  • valid key/value

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:enhancement New feature or request component:pipeline-editor pipeline editor labels Sep 28, 2022
@ptitzler ptitzler added this to the 3.12.0 milestone Sep 28, 2022
@elyra-bot
Copy link

elyra-bot bot commented Sep 28, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@@ -43,6 +43,7 @@
from elyra.pipeline.component_parameter import DisableNodeCaching
from elyra.pipeline.component_parameter import EnvironmentVariable
from elyra.pipeline.component_parameter import KubernetesAnnotation
from elyra.pipeline.component_parameter import KubernetesLabel

Check notice

Code scanning / CodeQL

Cyclic import

Import of module [elyra.pipeline.component_parameter](1) begins an import cycle.
Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM

@akchinSTC akchinSTC merged commit 7c027db into elyra-ai:main Oct 2, 2022
@ptitzler ptitzler deleted the add-label-configuration-support branch October 3, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-editor pipeline editor kind:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline editor: add support for custom pod labels
3 participants