-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for Script debugger #2971
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
I'm investigating the CI failures in https://github.com/karlaspuldaro/elyra/tree/test-branch - playing with test timeouts and adding one test at a time there to see what's going on |
4b8b9b6
to
8a7dd80
Compare
@kevin-bates you were right, looks like the execution order matters! |
Thanks for checking that @karlaspuldaro. This implies that another test (or more) is side-affecting the button's location (or something like that if I'm reading the test failures correctly). When I've dealt with this kind of thing before, it usually means a "binary search" exercise of placing the affected test in different locations until you find the test which your test immediately fails after, but works when moved one test prior. Then, the side-effecting test can be more closely examined if the solution hasn't been discovered in the course of the search exercise. It can be a long road, but also interesting once the solution is found. Good luck. 🍀 |
c5b2392
to
d1ce1da
Compare
@karlaspuldaro - since it appears we still don't know why the test location matters, could you please open an issue to revisit this as this is the kind of thing that can bite us down the road? I suspect it's one of the two "editor" tests that are causing the issue. This could be determined by moving this test immediately before those and ensuring it still passes. If there are failures, then this particular hypothesis is incorrect. |
Closes #2897
What changes were proposed in this pull request?
Integration test cases added in
scriptdebugger.ts
:All flaky on CI environmentFollow up note: new test file name has number on purpose (for now) so it is the first to run on CI as a workaround for failures, as suggested in this comment .
Follow up issue #2995 to track investigating other test(s) file(s) that may be affecting this new one.
Developer's Certificate of Origin 1.1