-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of cos_object_prefix
pipeline property
#2972
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I think using |
to represent the typehint Unions only work for python >=3.10.
anywho not a biggie, LGTM
Older python versions can use that syntax with
Agreed. |
Prior to this PR, pipelines with a
cos_object_prefix
defined will fail to run onmain
and the 3.12 release.What changes were proposed in this pull request?
This PR does a handful of related things. First, the
pipeline_parameters
property on thepipeline_definition.py
Pipeline
object is removed - it is no longer necessary now thatcos_object_prefix
is stored in thepipeline_defaults
stanza of the pipeline JSON. (Prior to the changes in #2780,cos_object_prefix
existed as a sibling to thepipeline_defaults
stanza). ThePIPELINE_META_PROPERTIES
constant is also no longer needed and is removed. A handful of helper methods are added tocomponent_parameter.py
and, as a result, theconvert_elyra_owned_properties
methods are simplified.The key-value pairs in the
pipeline_defaults
stanza are passed to thepipeline.py
Pipeline
object and accessed by the runtime processors in the same way as before, but now this property is namedpipeline_properties
rather thanpipeline_parameters
(in order to prepare for an implementation of #2936).Of note here is that no pipeline migration is necessary right now. In order to avoid a migration so soon in 3.13 (3.12 just required migration), a workaround is added to the backend that supports
cos_object_prefix
both as a child of thepipeline_defaults
and as a sibling. Seepipeline_definition:191:197
.How was this pull request tested?
cos_object_prefix
functionality; existing case that uses the same sample pipeline was also updated accordinglytest_create_yaml_complex_pipeline
) to covercos_object_prefix
and other functionality; mimics thecreate_test_file
test intest_airflow_processor.py
cos_object_prefix
defined in thepipeline_defaults
stanza of the pipeline jsoncos_object_prefix
defined in theapp_data
stanza of the pipeline jsonDeveloper's Certificate of Origin 1.1