-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for custom export file name #2999
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @salonee13 for implementing this enhancement, it looks great and works as expected :) For the integration test, you can add a new file (maybe call it
|
Could you also change the order in which information is rendered and rename the label to By moving the filename input to the bottom we group related information: the first inputs are specific to the runtime configuration that will be applied and the last three are specific to the exported file that will be produced:
|
…me to their own custom name if needed, if not, keeps it as the export path name Signed-off-by: Salonee <saloneepatel13@gmail.com>
…ormat of the export box Signed-off-by: Salonee <saloneepatel13@gmail.com>
0a33fde
to
6584360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving as-is because we decided offline to add the above-mentioned integration test a follow-up issue/PR
Thank you so much, Salonee! I'll be getting a lot of use out of this feature
Fixes #1417
What changes were proposed in this pull request?
Added functionality that allows the user to change the export file name to their own custom name if needed, if not, keeps it as the export path name
This shows the default export name:
This shows that it allows you to customize the export name to whatever you want:
This shows that the file exports and saves successfully with the custom export name:
How was this pull request tested?
Tested manually, see screenshots shown above. After the integration tests run, we will add a test to make sure this functionality works.
Developer's Certificate of Origin 1.1