-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pipeline parameters #3001
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
…to pipeline-params
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Martha Cryan <Martha.Cryan@ibm.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Note: the CodeQL warnings on this PR are 'the usual suspects' and have not been introduced by any changes made in this PR. (I think they may be triggered by the renaming of the |
I dismissed them. |
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Martha Cryan <Martha.Cryan@ibm.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks to you both for an awesome new feature!
Signed-off-by: Alan Chin <akchin@us.ibm.com>
This PR, once out of draft, will address all bullet points in #2994 with the exception of the CLI support.
Related: discussion #2970
What changes were proposed in this pull request?
This PR includes both the frontend and backend changes required to support pipeline parameters.
/pipeline/{processor_type}/parameters
PipelineParameter
object (one for each runtime type that supports parameters) and supply the schema with runtime-specific input typesparameter
for relevant custom component propertiespipeline_parameters
to the generic component propertiesPipeline
object after submissionNOTE: After some discussion, it was decided that generic pipelines should support the set of properties/parameters/etc that are supported by all runtimes (ie an intersection). While changes will be required to make this true of how properties are handled, this pipeline parameter support PR does follow this directive.
TODO
parameter
to useproperty
instead (where applicable)TODO
scompile
for mismatched KFP typesparameter
; component properties will appear as below in the pipeline JSONHow was this pull request tested?
Manual testing.
Added new backend tests.
NOTE: To test this PR as it relates to generic components, you will have to update the
ELYRA_BOOTSTRAP_SCRIPT_URL
env var to point to this branchhttps://raw.githubusercontent.com/kiersten-stokes/elyra/pipeline-params/elyra/kfp/bootstrapper.py
Developer's Certificate of Origin 1.1