-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address warnings produced by tests #3032
Address warnings produced by tests #3032
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
950b327
to
dbe325d
Compare
Moving to draft to try to address remaining warnings. |
The last 15 warnings will go away once this PR is merged. The reason is that one of the test resources is referenced within the I also fixed the test-artifact "leak" where the
This ultimately interferes with the dev's ability to check in changes w/o first removing those files or being explicit on each commit. And removed the use of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
Signed-off-by: Kevin Bates <kbates4@gmail.com>
c99f5cf
to
86d381d
Compare
This pull request takes a look at removing/ignoring a majority of the warnings that are produced by the server tests (via
make test-server
). Many of these warnings are ignored as they stem from upstream modules. That said, there are a number that have been resolved via code changes (primarily in tests) where things like file descriptors were not closed, etc.We should strive to get to a place where all warnings (except those explicitly handled) are treated as errors. This will enable their capture in a timely manner so things like
DeprecationWarning
can be handled and adjusted (if necessary) or added to the list of ignored warnings (if appropriate).This PR adds a number of warnings that are now ignored where, like caps on dependencies, a comment is provided indicating why the warning is ignored and/or additional context about the warning. At this point, the
error
filter is disabled. We could also consider ignoring these warnings using decorators in the test files themselves.It looks like the number of warnings varies based on which version of Python is in use, but I'm seeing the warnings decrease from thousands of warnings to these 15:
Developer's Certificate of Origin 1.1