-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generic component schema to unblock frontend changes to file browse feature #3040
Conversation
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Just pushed an update to use the rc with all the pipeline changes, once we confirm CI passes this should be good to merge (we may need to update the CI tests though) |
Updates include
|
Browse button is looking good. We probably shouldn't render it for output files though, because it might lead to confusion: By definition output files are produced when the node is executed. It appears that one cannot actually select a file (the file picker dialog shows up but selections are ignored), so this is more of a cosmetic usability issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Kiersten Stokes <kierstenstokes@gmail.com>
@kiersten-stokes thanks for pushing that last minute change! |
This PR contains small changes to support elyra-ai/pipeline-editor#208.
Signed-off-by: Kiersten Stokes kierstenstokes@gmail.com
What changes were proposed in this pull request?
Change the generic component schema for file-based arrays (file dependencies and outputs) to the new format that the frontend is expecting.
Code sandbox to be added by @marthacryan
How was this pull request tested?
Tests passing
Developer's Certificate of Origin 1.1