Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape string property inputs #3048

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Dec 8, 2022

Closes #3047

Signed-off-by: Patrick Titzler ptitzler@us.ibm.com

What changes were proposed in this pull request?

Escape user-provided property values that are of type string:

image

How was this pull request tested?

Using the component spec referenced in the original issue, I've specified valid JSON strings as input, such as {"test_dict": 99} and ["array_item_1", "array_item_2"].

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added the kind:bug Something isn't working label Dec 8, 2022
@ptitzler ptitzler added this to the 3.14.0 milestone Dec 8, 2022
@ptitzler

This comment was marked as resolved.

@ptitzler ptitzler added the component:pipeline-editor pipeline editor label Dec 8, 2022
Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested several components and strings are properly delimited!

@akchinSTC akchinSTC merged commit acf0893 into elyra-ai:main Dec 9, 2022
@ptitzler ptitzler deleted the sanitize-input branch December 10, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-editor pipeline editor kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KFP: Cannot parse dictionary as input
3 participants