Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease jupyter_core floor, cap nbclient for 3.7 #3071

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

kevin-bates
Copy link
Member

As discussed in #3069, conda installs of Elyra will fail because the dependency of jupyter_core >= 4.11.2 cannot be resolved. This is because conda removed support for Python 3.7 last August.

This pull request will allow for conda installations of Elyra to succeed, albeit supporting versions of jupyter_core <= 4.11.1. This change also resulted in capping nbclient <= 0.7.0 for Python 3.7 since more recent versions of nbclient require jupyter_core >= 4.12.

Resolves: #3069
Signed-off-by: Kevin Bates kbates4@gmail.com

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Kevin Bates <kbates4@gmail.com>
@akchinSTC akchinSTC added the component:build build and build related issues(dependencies and docker) label Jan 9, 2023
@akchinSTC
Copy link
Member

We can keep this open for discussion tomorrow at scrum, and close when necessary

@lresende
Copy link
Member

lresende commented Jan 9, 2023

Should we just remove support for Python 3.7?

@kevin-bates
Copy link
Member Author

Should we just remove support for Python 3.7?

I agree. I think the bigger question is in what release can/should this removal occur in - 3.15 or 4.0?

@kevin-bates
Copy link
Member Author

We should still merge this PR since it's limiting functionality on python releases > 3.7. We can talk about dropping 3.7 independently.

@kevin-bates kevin-bates merged commit 438b5b9 into elyra-ai:main Jan 12, 2023
@kevin-bates kevin-bates deleted the decrease-jupyter_core-floor branch January 12, 2023 01:19
@ptitzler ptitzler added this to the 3.14.2 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elyra Conda install on py37 fails because of jupyter_core>=4.11.2
4 participants