Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caps in dependencies for kfp-related packages #3076

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

kevin-bates
Copy link
Member

This pull request removes caps on jupyter_events, jsonschema, and pyyaml that were originally introduced due to kfp. Since kfp introduced artificial caps on jsonschema<4 and pyyaml<6, yet jupyter_events required jsonschema>=4 and pyyaml>=6 an impossible resolution was introduced. Fortunately, the floors imposed in jupyter_events were aggressive and we were able to contribute the necessary changes to decrease the floors of jsonschema and pyyaml to 3.2.0 and 5.3, respectively. Since those are the floors used by kfp the set of packages can be resolved.

The decrease of the floor in jsonschema was non-trivial and its evolution can be found here, if interested. jupyter_events 0.6.1 resolved #3070, but then the pyyaml resolution issue was encountered once the cap for jupyter_events was lifted. This latter issue was resolved in jupyter_events 0.6.2 - resulting in its current floor.

The update of test_requirements.txt to include pytest_jupyter was necessary to get tests to run now that #3070 is resolved. We should really be using the set of test dependencies listed in pyproject.toml and remove that file, but that's another story. At this moment the two sets of packages are in-sync.

(Note: test failures still occur due to #3072.)

Resolves: #3070

Signed-off-by: Kevin Bates kbates4@gmail.com

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Kevin Bates <kbates4@gmail.com>
@kevin-bates kevin-bates added the dependencies Pull requests that update a dependency file label Jan 10, 2023
@kevin-bates kevin-bates changed the title Remove unnecessary caps in dependencies for kfp-related packages Remove caps in dependencies for kfp-related packages Jan 10, 2023
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akchinSTC akchinSTC merged commit 0109ea3 into elyra-ai:main Jan 11, 2023
@kevin-bates kevin-bates deleted the update-jupyter_events-floor branch January 11, 2023 00:56
@ptitzler ptitzler added this to the 3.14.2 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not launch after installing elyra
3 participants