Remove caps in dependencies for kfp-related packages #3076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes caps on
jupyter_events
,jsonschema
, andpyyaml
that were originally introduced due tokfp
. Sincekfp
introduced artificial caps onjsonschema<4
andpyyaml<6
, yetjupyter_events
requiredjsonschema>=4
andpyyaml>=6
an impossible resolution was introduced. Fortunately, the floors imposed injupyter_events
were aggressive and we were able to contribute the necessary changes to decrease the floors ofjsonschema
andpyyaml
to3.2.0
and5.3
, respectively. Since those are the floors used bykfp
the set of packages can be resolved.The decrease of the floor in
jsonschema
was non-trivial and its evolution can be found here, if interested.jupyter_events 0.6.1
resolved #3070, but then thepyyaml
resolution issue was encountered once the cap forjupyter_events
was lifted. This latter issue was resolved injupyter_events 0.6.2
- resulting in its current floor.The update of
test_requirements.txt
to includepytest_jupyter
was necessary to get tests to run now that #3070 is resolved. We should really be using the set of test dependencies listed inpyproject.toml
and remove that file, but that's another story. At this moment the two sets of packages are in-sync.(Note: test failures still occur due to #3072.)
Resolves: #3070
Signed-off-by: Kevin Bates kbates4@gmail.com
Developer's Certificate of Origin 1.1