Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int parameter handling of default zero #3090

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

marthacryan
Copy link
Member

Fixes #3087.

Signed-off-by: Martha Cryan Martha.Cryan@ibm.com

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Martha Cryan <Martha.Cryan@ibm.com>
@marthacryan marthacryan requested a review from ptitzler January 25, 2023 20:21
@ptitzler ptitzler added the kind:bug Something isn't working label Jan 25, 2023
@ptitzler ptitzler added this to the 3.14.2 milestone Jan 25, 2023
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Zero (default or entered as a custom value) is now accepted as a valid value.

image

@akchinSTC akchinSTC merged commit 92ce34d into elyra-ai:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI export/submit handling of INT pipeline parameter with default value of 0
3 participants