Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function format to conform to black v23 linting #3097

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

akchinSTC
Copy link
Member

Signed-off-by: Alan Chin akchin@us.ibm.com

Format elyra existing functions to conform to new linting rules.
The new release of black v23 causes issues when linting elyra functions due to a new rule (removes empty line after function def) See example :

--- a/elyra/tests/metadata/test_metadata.py
+++ b/elyra/tests/metadata/test_metadata.py
@@ -49,7 +49,6 @@ os.environ["METADATA_TESTING"] = "1"  # Enable metadata-tests schemaspace
 
 # ########################## MetadataManager Tests ###########################
 def test_manager_add_invalid(tests_manager):
-
     with pytest.raises(ValueError):
         MetadataManager(schemaspace="invalid")

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Alan Chin <akchin@us.ibm.com>
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @akchinSTC! (I guess we should ensure the tests are cool before merging.)

@ptitzler ptitzler linked an issue Feb 1, 2023 that may be closed by this pull request
@ptitzler ptitzler added the component:build build and build related issues(dependencies and docker) label Feb 1, 2023
@akchinSTC akchinSTC merged commit 2ab9194 into elyra-ai:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New major release of 'black' breaks builds
3 participants