Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Jupyterlab 1.x and 2.x from documentation #3112

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

ptitzler
Copy link
Member

Remove references to Elyra versions that require Jupyterlab v1 (last update 08/21) and v2 (last update 06/21) from the documentation. The main goal is to discourage users from deploying Elyra versions that are no longer under active development.

Signed-off-by: Patrick Titzler ptitzler@us.ibm.com

What changes were proposed in this pull request?

See above.

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
@ptitzler ptitzler added area:documentation Improvements or additions to documentation status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. labels Feb 14, 2023
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. My "grep -ri JupyterLab" exercise did yield another possible change. In the NOTE: and the bottom of this section, we reference a JupyterLab release of 2.2.9 that might give a false impression.

ptitzler and others added 2 commits February 15, 2023 10:14
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
Signed-off-by: Alan Chin <akchin@us.ibm.com>
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Patrick and Alan!

@akchinSTC akchinSTC merged commit 94f3b17 into elyra-ai:main Feb 16, 2023
@ptitzler ptitzler deleted the legacy-support branch February 16, 2023 22:48
@ptitzler ptitzler removed the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants