-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide binder links and references #3119
Conversation
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments (and an opinion 😄). I personally find the hell that is version-string management in documentation to not be worth the effort.
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to comment out lines of code, we should ensure the lines are working since that will be assumed when folks decide to uncomment those lines.
Personally, I view this as the role of source code control history and advocate their removal altogether.
Signed-off-by: Patrick Titzler <ptitzler@us.ibm.com>
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ptitzler - these changes look good.
[Updated PR]
What changes were proposed in this pull request?
See above
How was this pull request tested?
Reviewed the updated readme.md and built documentation
Developer's Certificate of Origin 1.1