Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Elyra extensions to support JupyterLab 4.x #3201

Merged
merged 53 commits into from
Dec 28, 2024

Conversation

lresende
Copy link
Member

@lresende lresende commented Dec 18, 2023

What changes were proposed in this pull request?

Migrate Elyra extensions to support JupyterLab 4.x

Fixes #3137

How was this pull request tested?

Building and running on JupyterLab 4.x

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Dec 18, 2023
@lresende lresende requested a review from kevin-bates December 18, 2023 18:08
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the build failures are a temporary hurdle. Thanks for dealing with the @lresende!

@lresende lresende force-pushed the lresende-lab4 branch 8 times, most recently from a5b1686 to 6410a77 Compare December 20, 2023 04:25
@lresende
Copy link
Member Author

I have made some progress here, but I would appreciate if I could get some help on the UI pieces, in particular on UI-components... @marthacryan @karlaspuldaro @ajbozarth and others feel free to send prs to this branch as time permits... I completely understand if you are not able to.

@@ -41,7 +41,12 @@ jobs:
/home/runner/.cache/Cypress
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
- name: Install
run: yarn install --frozen-lockfile && tsc -v
run: |
corepack prepare yarn@3.5.0 --activate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is causing build failure, maybe it's best to use a stable version of yarn

@hadesto
Copy link

hadesto commented Jun 7, 2024

hello! is this pull request still being worked on? it would be amazing to have support for JL4 now that JL3 has an official sunset date. Is there any support required from the community? Thank you!

@lresende
Copy link
Member Author

lresende commented Jun 8, 2024

There is a pr against this pr, let me merge that over the weekend and then others can jump in to help finish any remaining items

@hadesto
Copy link

hadesto commented Jun 12, 2024

thanks for the quick response!

@ederign
Copy link
Contributor

ederign commented Aug 14, 2024

hi @lresende, thank you so much for this work! Where are these 'remaining items' located? I would love to figure out ways to help! (at least testing it)

@harshad16
Copy link
Contributor

thank you so much for this work! Where are these 'remaining items' located? I would love to figure out ways to help! (at least testing it)

@ederign they are opened as PR to the branch, here: lresende#1

@Ekzz0
Copy link

Ekzz0 commented Dec 16, 2024

Hi @lresende, this migration still being worked on? should we expect changes in the near future?

@lresende
Copy link
Member Author

@Ekzz0 we need to resolve some of these conflicts, but, at a high level, the branch is working with JupyterLab 4.2.5

@lresende lresende mentioned this pull request Dec 21, 2024
7 tasks
@lresende lresende added this to the 4.0.0 milestone Dec 24, 2024
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
xinchaochen8 and others added 10 commits December 25, 2024 08:37
trying to adjust workflow build issue
---------

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Signed-off-by: shalberd <21118431+shalberd@users.noreply.github.com>
Co-authored-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Co-authored-by: Eder Ignatowicz <ignatowicz@gmail.com>
Co-authored-by: Edson Tirelli <ed.tirelli@gmail.com>
Co-authored-by: Harshad Reddy Nalla <hnalla@redhat.com>
Co-authored-by: Sven Thoms <21118431+shalberd@users.noreply.github.com>
Should be separate pr
@lresende
Copy link
Member Author

I have rebased and resolved conflicts, also removed some unrelated changes that can come as another pr to simplify review... let's wrap this up.

@caponetto
Copy link
Contributor

@lresende I've sent two PRs targeting your branch to make it green on the CI.

Please take a look at them when you have some time.

I think we should make the CI for this PR green first, and then work on details (for instance reverting those unrelated changes and/or fixing bugs).

caponetto and others added 3 commits December 27, 2024 18:24
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
@lresende lresende removed the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Dec 28, 2024
Signed-off-by: Luciano Resende <lresende@apple.com>
@shalberd
Copy link
Contributor

shalberd commented Dec 28, 2024

Ah, yes, that is the failed yarn cypress integration test again, the one that is flaky. Not flaky anymore, this time, though, Pipeline Editor tests partly failing. Still, much better than before already.
"Snapshot Match Error: Value does not match stored snapshot" expected content is null or empty, it seems.

Signed-off-by: Luciano Resende <lresende@apple.com>
@lresende
Copy link
Member Author

@caponetto It seems like the last test issue is related to some properties not being saved on the pipeline files, which fail to match the existing snapshot. I noticed you made some changes in that area recently. Would you have some time to help identify what's going on?

@caponetto
Copy link
Contributor

@lresende please see lresende#5

@lresende
Copy link
Member Author

lresende commented Dec 28, 2024

Thank you @caponetto , so are you saying that the empty fields are not being saved to pipelines anymore and it's ok to remove them? Particularly as it is working on main branch.

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
@lresende
Copy link
Member Author

Thank you @caponetto , so are you saying that the empty fields are not being saved to pipelines anymore and it's ok to remove them? Particularly as it is working on main branch.

Never mind, I see the difference in the duplicate/different block.

@lresende lresende merged commit 14dad20 into elyra-ai:main Dec 28, 2024
19 of 20 checks passed
@lresende lresende deleted the lresende-lab4 branch December 28, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JupyterLab 4.x