-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Elyra extensions to support JupyterLab 4.x #3201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming the build failures are a temporary hurdle. Thanks for dealing with the @lresende!
a5b1686
to
6410a77
Compare
I have made some progress here, but I would appreciate if I could get some help on the UI pieces, in particular on UI-components... @marthacryan @karlaspuldaro @ajbozarth and others feel free to send prs to this branch as time permits... I completely understand if you are not able to. |
110767d
to
7567988
Compare
7567988
to
95332e5
Compare
.github/workflows/build.yml
Outdated
@@ -41,7 +41,12 @@ jobs: | |||
/home/runner/.cache/Cypress | |||
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | |||
- name: Install | |||
run: yarn install --frozen-lockfile && tsc -v | |||
run: | | |||
corepack prepare yarn@3.5.0 --activate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is causing build failure, maybe it's best to use a stable version of yarn
hello! is this pull request still being worked on? it would be amazing to have support for JL4 now that JL3 has an official sunset date. Is there any support required from the community? Thank you! |
There is a pr against this pr, let me merge that over the weekend and then others can jump in to help finish any remaining items |
thanks for the quick response! |
hi @lresende, thank you so much for this work! Where are these 'remaining items' located? I would love to figure out ways to help! (at least testing it) |
@ederign they are opened as PR to the branch, here: lresende#1 |
Hi @lresende, this migration still being worked on? should we expect changes in the near future? |
@Ekzz0 we need to resolve some of these conflicts, but, at a high level, the branch is working with JupyterLab 4.2.5 |
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
This reverts commit b2630c7.
This reverts commit 9ab11eb.
trying to adjust workflow build issue
--------- Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com> Signed-off-by: shalberd <21118431+shalberd@users.noreply.github.com> Co-authored-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com> Co-authored-by: Eder Ignatowicz <ignatowicz@gmail.com> Co-authored-by: Edson Tirelli <ed.tirelli@gmail.com> Co-authored-by: Harshad Reddy Nalla <hnalla@redhat.com> Co-authored-by: Sven Thoms <21118431+shalberd@users.noreply.github.com>
Should be separate pr
9fcc9e3
to
3f9d206
Compare
I have rebased and resolved conflicts, also removed some unrelated changes that can come as another pr to simplify review... let's wrap this up. |
@lresende I've sent two PRs targeting your branch to make it green on the CI. Please take a look at them when you have some time.
I think we should make the CI for this PR green first, and then work on details (for instance reverting those unrelated changes and/or fixing bugs). |
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
Signed-off-by: Luciano Resende <lresende@apple.com>
Ah, yes, that is the failed yarn cypress integration test again, the one that is flaky. Not flaky anymore, this time, though, Pipeline Editor tests partly failing. Still, much better than before already. |
Signed-off-by: Luciano Resende <lresende@apple.com>
b50d20d
to
9d94dd2
Compare
@caponetto It seems like the last test issue is related to some properties not being saved on the pipeline files, which fail to match the existing snapshot. I noticed you made some changes in that area recently. Would you have some time to help identify what's going on? |
@lresende please see lresende#5 |
Thank you @caponetto , so are you saying that the empty fields are not being saved to pipelines anymore and it's ok to remove them? Particularly as it is working on main branch. |
Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
Never mind, I see the difference in the duplicate/different block. |
What changes were proposed in this pull request?
Migrate Elyra extensions to support JupyterLab 4.x
Fixes #3137
How was this pull request tested?
Building and running on JupyterLab 4.x
Developer's Certificate of Origin 1.1