Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python instead of curl to download test file on validate-runtime-image target #3257

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

caponetto
Copy link
Contributor

What changes were proposed in this pull request?

Fixes https://github.com/elyra-ai/elyra/actions/runs/12429390840/job/34702792058

Apparently, the new pytorch image doesn't include curl anymore, which causes validate-runtime-image to fail.

How was this pull request tested?

Tested on my fork through this run.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

…image target

Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
@caponetto
Copy link
Contributor Author

cc @lresende

@shalberd
Copy link
Contributor

looks good to me, thank you, @caponetto, I have noticed the error in my PR as well.

@caponetto
Copy link
Contributor Author

Elyra Tests / Lint Server is also failing on main so I think this PR is good to be merged.

@lresende lresende merged commit bfc97e6 into elyra-ai:main Dec 20, 2024
16 of 17 checks passed
@shalberd
Copy link
Contributor

shalberd commented Dec 20, 2024

@caponetto I made some changes lint-server section related in my PR. E226 related

a8722fa#diff-4f0535277f973d16f4972b236075db911a09293effd07706b45fe787c133e18e

wondering if there, the step validate-images will run through now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants