-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for pipeline properties #122
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 80.42% 79.23% -1.19%
==========================================
Files 36 40 +4
Lines 1272 1315 +43
Branches 291 301 +10
==========================================
+ Hits 1023 1042 +19
- Misses 195 213 +18
- Partials 54 60 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the properties panel refactor looks really good, nice work 😊
just a couple small changes around the form control stuff
packages/pipeline-editor/src/CustomFormControls/StringControl.tsx
Outdated
Show resolved
Hide resolved
packages/pipeline-editor/src/CustomFormControls/StringControl.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/pipeline-editor/src/CustomFormControls/DisplayControl.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick Bourdakos <bourdakos1@gmail.com>
Added to address elyra-ai/elyra#1699.

Adds a tab to the right side panel and adds the ability to use a
textarea
andreadonly
for text inputs:Uses a given properties config to display the pipeline properties editor. Doesn't currently handle the case that there is none given - in that case, should the tab be removed, or should it just display a message like "No pipeline properties defined"?
Adds pipeline properties into a field
pipeline_properties
.Todo:
app_data
in the pipeline JSONDeveloper's Certificate of Origin 1.1