Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for pipeline properties #122

Merged
merged 16 commits into from
Jun 4, 2021

Conversation

marthacryan
Copy link
Member

@marthacryan marthacryan commented May 25, 2021

Added to address elyra-ai/elyra#1699.
Adds a tab to the right side panel and adds the ability to use a textarea and readonly for text inputs:
image

Uses a given properties config to display the pipeline properties editor. Doesn't currently handle the case that there is none given - in that case, should the tab be removed, or should it just display a message like "No pipeline properties defined"?

Adds pipeline properties into a field pipeline_properties.

Todo:

  • Move pipeline properties into app_data in the pipeline JSON

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@marthacryan marthacryan requested a review from bourdakos1 May 25, 2021 21:30
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #122 (fa914b0) into master (25b9a0f) will decrease coverage by 1.18%.
The diff coverage is 59.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   80.42%   79.23%   -1.19%     
==========================================
  Files          36       40       +4     
  Lines        1272     1315      +43     
  Branches      291      301      +10     
==========================================
+ Hits         1023     1042      +19     
- Misses        195      213      +18     
- Partials       54       60       +6     
Impacted Files Coverage Δ
...ne-editor/src/CustomFormControls/StringControl.tsx 84.44% <0.00%> (-1.92%) ⬇️
...CustomFormControls/validators/string-validators.ts 73.33% <ø> (ø)
...e-editor/src/properties-panels/properties-utils.ts 100.00% <ø> (ø)
...tor/src/properties-panels/useActiveFormItemShim.ts 100.00% <ø> (ø)
...ditor/src/properties-panels/PipelineProperties.tsx 16.66% <16.66%> (ø)
...kages/pipeline-editor/src/PipelineEditor/index.tsx 44.22% <38.46%> (-0.76%) ⬇️
...e-editor/src/CustomFormControls/DisplayControl.tsx 50.00% <50.00%> (ø)
...e-editor/src/properties-panels/PropertiesPanel.tsx 81.81% <83.33%> (ø)
...ne-editor/src/properties-panels/NodeProperties.tsx 85.71% <85.71%> (ø)
...ckages/pipeline-editor/src/ThemeProvider/styles.ts 93.91% <100.00%> (+0.16%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b9a0f...fa914b0. Read the comment docs.

@marthacryan marthacryan requested a review from bourdakos1 May 28, 2021 21:29
@marthacryan marthacryan marked this pull request as ready for review June 1, 2021 14:02
Copy link
Member

@bourdakos1 bourdakos1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the properties panel refactor looks really good, nice work 😊

just a couple small changes around the form control stuff

@marthacryan marthacryan requested a review from bourdakos1 June 3, 2021 15:37
Copy link
Member

@bourdakos1 bourdakos1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Nick Bourdakos <bourdakos1@gmail.com>
@lresende lresende merged commit 565d67b into elyra-ai:master Jun 4, 2021
@marthacryan marthacryan deleted the pipeline-properties branch March 14, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants