Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path issue in Scalar config #185

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

bhaleraosaurabh
Copy link
Contributor

@bhaleraosaurabh bhaleraosaurabh commented Jan 30, 2025

When using a prefix, the plugin tries to fetch the scalar config from an incorrect path as mentioned in issues #161, #183, #151 . This can be seen in the screenshots below.

This PR enables successful fetching of the Scalar config from the correct URL whether a prefix is used or not and even if the prefix is nested.

closes #161
closes #183
closes #151
closes #157

elysia with prefix
Incorrect JSON path

No prefix
No prefix on elysia

Elysia swagger with corrected path
nested prefix

@antoniel
Copy link

antoniel commented Feb 8, 2025

+1

@dodas
Copy link
Contributor

dodas commented Feb 21, 2025

bump. this fixes my issue when Scalar UI tries to load the openapi schema from /swagger/json, even though it should be requesting /api/swagger/json.
cc @SaltyAom

Co-authored-by: Jozef Mikuláš <jmikulas.sk@gmail.com>
@bhaleraosaurabh
Copy link
Contributor Author

Could we please have it merged @SaltyAom ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants