Changed no_basename() to suppress_basename() in FileSpec for consiste… #139
clippy
12 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 12 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.77.0-nightly (88189a71e 2024-01-19)
- cargo 1.77.0-nightly (1ae631085 2024-01-17)
- clippy 0.1.77 (88189a7 2024-01-19)
Annotations
Check failure on line 254 in src/writers/file_log_writer/builder.rs
github-actions / clippy
this call to `as_ref.map(...)` does nothing
error: this call to `as_ref.map(...)` does nothing
--> src/writers/file_log_writer/builder.rs:254:13
|
254 | self.o_rotation_config.as_ref().map(Clone::clone),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.o_rotation_config.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
Check failure on line 251 in src/writers/file_log_writer/builder.rs
github-actions / clippy
this call to `as_ref.map(...)` does nothing
error: this call to `as_ref.map(...)` does nothing
--> src/writers/file_log_writer/builder.rs:251:35
|
251 | o_create_symlink: self.cfg_o_create_symlink.as_ref().map(Clone::clone),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.cfg_o_create_symlink.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
note: the lint level is defined here
--> src/lib.rs:4:9
|
4 | #![deny(clippy::all)]
| ^^^^^^^^^^^
= note: `#[deny(clippy::useless_asref)]` implied by `#[deny(clippy::all)]`
Check failure on line 28 in src/logger_handle.rs
github-actions / clippy
item in documentation is missing backticks
error: item in documentation is missing backticks
--> src/logger_handle.rs:28:8
|
28 | /// to flush() the logger explicitly, and to reconfigure the used `FileLogWriter` --
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: `#[deny(clippy::doc_markdown)]` implied by `#[deny(clippy::pedantic)]`
help: try
|
28 | /// to `flush()` the logger explicitly, and to reconfigure the used `FileLogWriter` --
| ~~~~~~~~~
Check failure on line 254 in src/writers/file_log_writer/builder.rs
github-actions / clippy
this call to `as_ref.map(...)` does nothing
error: this call to `as_ref.map(...)` does nothing
--> src/writers/file_log_writer/builder.rs:254:13
|
254 | self.o_rotation_config.as_ref().map(Clone::clone),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.o_rotation_config.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
Check failure on line 251 in src/writers/file_log_writer/builder.rs
github-actions / clippy
this call to `as_ref.map(...)` does nothing
error: this call to `as_ref.map(...)` does nothing
--> src/writers/file_log_writer/builder.rs:251:35
|
251 | o_create_symlink: self.cfg_o_create_symlink.as_ref().map(Clone::clone),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.cfg_o_create_symlink.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
note: the lint level is defined here
--> src/lib.rs:4:9
|
4 | #![deny(clippy::all)]
| ^^^^^^^^^^^
= note: `#[deny(clippy::useless_asref)]` implied by `#[deny(clippy::all)]`
Check failure on line 104 in src/file_spec.rs
github-actions / clippy
empty String is being created manually
error: empty String is being created manually
--> src/file_spec.rs:104:25
|
104 | self.basename = "".into();
| ^^^^^^^^^ help: consider using: `String::new()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new
note: the lint level is defined here
--> src/lib.rs:5:9
|
5 | #![deny(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::manual_string_new)]` implied by `#[deny(clippy::pedantic)]`
Check failure on line 28 in src/logger_handle.rs
github-actions / clippy
item in documentation is missing backticks
error: item in documentation is missing backticks
--> src/logger_handle.rs:28:8
|
28 | /// to flush() the logger explicitly, and to reconfigure the used `FileLogWriter` --
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: `#[deny(clippy::doc_markdown)]` implied by `#[deny(clippy::pedantic)]`
help: try
|
28 | /// to `flush()` the logger explicitly, and to reconfigure the used `FileLogWriter` --
| ~~~~~~~~~
Check failure on line 120 in src/write_mode.rs
github-actions / clippy
field `1` is never read
error: field `1` is never read
--> src/write_mode.rs:120:31
|
120 | BufferAndFlushWith(usize, Duration),
| ------------------ ^^^^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
120 | BufferAndFlushWith(usize, ()),
| ~~
Check failure on line 142 in src/trc.rs
github-actions / clippy
field `0` is never read
error: field `0` is never read
--> src/trc.rs:142:29
|
142 | pub struct SpecFileNotifier(Option<Debouncer<RecommendedWatcher>>);
| ---------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| field in this struct
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
142 | pub struct SpecFileNotifier(());
| ~~
Check failure on line 104 in src/file_spec.rs
github-actions / clippy
empty String is being created manually
error: empty String is being created manually
--> src/file_spec.rs:104:25
|
104 | self.basename = "".into();
| ^^^^^^^^^ help: consider using: `String::new()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new
note: the lint level is defined here
--> src/lib.rs:5:9
|
5 | #![deny(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::manual_string_new)]` implied by `#[deny(clippy::pedantic)]`
Check failure on line 120 in src/write_mode.rs
github-actions / clippy
field `1` is never read
error: field `1` is never read
--> src/write_mode.rs:120:31
|
120 | BufferAndFlushWith(usize, Duration),
| ------------------ ^^^^^^^^
| |
| field in this variant
|
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
120 | BufferAndFlushWith(usize, ()),
| ~~
Check failure on line 142 in src/trc.rs
github-actions / clippy
field `0` is never read
error: field `0` is never read
--> src/trc.rs:142:29
|
142 | pub struct SpecFileNotifier(Option<Debouncer<RecommendedWatcher>>);
| ---------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| field in this struct
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
142 | pub struct SpecFileNotifier(());
| ~~