[Fix #1185] Move ask-for directory code after ess-r-mode startup #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vspinu
force-pushed
the
ask-for-dir-after-ess-inf
branch
from
30d574c to
347d3b4
Compare
.. and make it to take precedence over ess-startup-directory-function. Document the usage.
vspinu
force-pushed
the
ask-for-dir-after-ess-inf
branch
from
347d3b4 to
f3c196d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a problem with #1185
The asking for the directory happens before the
inferior-ess-r-modeis installed into the buffer, which means the mode hooks that setproject-find-directoryhave not run yet. Let binding around the call toinferior-essas it currently is not good because of the warning in #1185.The proposed solution is not ideal either because the functions which are run in the mode-hook don't see the new
default-directory. I am not sure if this is acceptable.All other ways to fix this I can think of are rather hacky 🤔