Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of starting directory #457

Merged
merged 24 commits into from
Oct 29, 2017

Commits on Oct 29, 2017

  1. Disaggregate setqs

    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    1536e1a View commit details
    Browse the repository at this point in the history
  2. Clean up comments

    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    1079d1f View commit details
    Browse the repository at this point in the history
  3. Refactor loop to proper form

    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    7565e00 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    db73034 View commit details
    Browse the repository at this point in the history
  5. Refactor ess-get-directory()

    Separate into:
    
    - inferior-ess--default-directory()
    - inferior-ess--get-directory()
    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    b78ad41 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2dd3d23 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3f22ff4 View commit details
    Browse the repository at this point in the history
  8. Use project-current() for checking default directory

    Now that R packages are registered as projects this will return their
    root directory as default.
    
    Eventually we might want to deprecate `ess-directory-function` in
    favour of projects once Emacs 25.1 becomes the oldest supported version.
    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    01e1b3c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    36dbbd2 View commit details
    Browse the repository at this point in the history
  10. Use ess-default-directory instead of default-directory

    `default-directory` is unset by the time the inferior is restarted
    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    9907220 View commit details
    Browse the repository at this point in the history
  11. Better names for directory helpers

    Renamed inferior-ess--get-directory() to inferior-ess--maybe-prompt-startup-directory()
    Renamed inferior-ess--default-directory() to inferior-ess--get-startup-directory()
    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    581ed38 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    eb46c8d View commit details
    Browse the repository at this point in the history
  13. Proper defvaralias

    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    463aeb7 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    115f86c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    5a67ea5 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    b736d63 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    00a490a View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    fa59522 View commit details
    Browse the repository at this point in the history
  19. Add ess-r-package-name()

    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    924ddaa View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    a7277b3 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    63d07c2 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    2924762 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    4b2e38e View commit details
    Browse the repository at this point in the history
  24. Prefer the tests directory over package roots

    cc @vspinu. This is currently a bit ugly, we'll need to move all the
    dialect-specific stuff out of `ess-inf.el` at some point.
    lionel- committed Oct 29, 2017
    Configuration menu
    Copy the full SHA
    5a7fb1c View commit details
    Browse the repository at this point in the history