Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyrolo #822

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Hyrolo #822

merged 5 commits into from
Aug 12, 2024

Conversation

julian-hoch
Copy link
Contributor

Brief summary of what the package does

hyrolo is part of hyperbole, basically a record manager

Direct link to the package repository

https://www.gnu.org/software/hyperbole/

Checklist

I dont know how to check "byte-compiles cleanly", but should be fine ?

Assume you're working on mpc mode:

  • [? ] byte-compiles cleanly
  • [ x] M-x checkdoc is happy. Don't manually write (provide 'evil-collection-mpc), M-x checkdoc can do it automatically for you
  • define evil-collection-mpc-setup with defun
  • [ x] define evil-collection-mpc-mode-maps with defconst
  • [ x] All functions should start with evil-collection-mpc-

@condy0919
Copy link
Collaborator

condy0919 commented Jul 30, 2024

I dont know how to check "byte-compiles cleanly", but should be fine ?

M-x byte-compile-file

@condy0919
Copy link
Collaborator

condy0919 commented Jul 30, 2024

Does hyrolo provide 'hyrolo? e.g. (provides 'hyrolo) at the end of the file.

@julian-hoch
Copy link
Contributor Author

Thanks for the update.
M-x byte-compile-file
runs fine.
And here is the link to hyrolo.el, if that answers your question (it does provide hyrolo).
https://github.com/rswgnu/hyperbole/blob/master/hyrolo.el

modes/hyrolo/evil-collection-hyrolo.el Show resolved Hide resolved
@condy0919
Copy link
Collaborator

Compiling /home/runner/work/evil-collection/evil-collection/modes/hyrolo/evil-collection-hyrolo.el... the following functions are not known to be defined: hyrolo-to-previous-loc, hyrolo-to-next-loc, hyrolo-outline-show-all, hyrolo-overview

declare-function these functions first.

@condy0919 condy0919 merged commit adc69d2 into emacs-evil:master Aug 12, 2024
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants