Initial attempt at evil-based key bindings #2
Conversation
No popups are fixed yet
Use `evil-define-key` and move jump commands to g prefix
|
@tarsius what's the easiest way to move popup commands? |
|
@justbur |
|
I tried this yesterday. Let me be more specific. :-P
For example. The popup argument is the symbol of the function that triggers the popup. |
|
@TheBB I can give you access to my branch if you want to help :-P
|
|
Sure, why not. |
|
@TheBB ok you should have access now. I'm just on master. I added a TODO list in the header. |
In principle this will be simpler than normal, because there should be less conflicts.
| (evil-define-key 'motion git-rebase-mode-map (kbd "RET") 'git-rebase-show-commit) | ||
| (evil-define-key 'motion git-rebase-mode-map (kbd "SPC") 'magit-diff-show-or-scroll-up) | ||
| (evil-define-key 'motion git-rebase-mode-map (kbd "!") 'git-rebase-exec) ; was x | ||
| (evil-define-key 'motion git-rebase-mode-map (kbd "c") 'git-rebase-pick) |
There was a problem hiding this comment.
Since p isn't used for anything else, you could use it here.
There was a problem hiding this comment.
Good idea. I was trying to think of a use for p
Redefined :actions to fix string portion at end
Try h with evil-define-key
evil-define-key doesn't work for maps set in text property
|
@tarsius For the popups, it seems like To give an example, |
|
Yes, that's right. It was resolved with |
|
@justbur I would like |
|
@cpaulik @nixmaniack You're only answering part of my question. Perhaps I wasn't clear. There are two types of section movement Right now, I hear you say |
This should have the same effect as trying to populate all the keys initially, but is much cleaner and less error prone.
C-u is only scroll-up if evil-want-C-u-scroll is non-nil
Was an artifact from an old idea for J and K
|
This is what is expected right now. Since I don't use |
|
I think gj and gk are good fits for the -sibling commands. |
C-j/C-k move by section, and gj/gk move by section-sibling Also, fix up comments in header
|
@cpaulik @nixmaniack pushed the changes. Refer to the table at the beginning of the issue. I think you will both be happy |
Also, automatically reformat git-rebase buffer help section
Favor remapping commands found in parent maps instead
Initial official version of evil-magit bindings
cc @TheBB @syl20bnr
I'm not done with this, but this is at least a starting point. I think some of the choices need some work. I didn't know where to put rename for instance. I also need to fix the popups.
Please give feedback on what you'd like to see changed. Here's a table showing the basic ideas
Other/Additions