Fix bugs in evil-with-undo' and evil-undo-pop' with undo-tree.
#1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses emacs-evil#1074 - evil-with-undo: nconc'ing onto front of buffer-undo-list here can corrupt buffer-undo-list when in undo-tree-mode in rare circumstances (see issue emacs-evil#1074 referenced above). Since evil-temporary-undo was always nil when executing @Body anyway, and reset to nil at end, other elisp code could never see a non-nil value for it anyway here. So we fix the nconc bug by simplifying the code, and getting rid of the redundant evil-temporary-undo juggling in the process. - evil-undo-pop: This function called `undo' directly from Elisp, which is almost always a bug in undo-tree-mode. Fix this by calling undo-tree-undo instead when in undo-tree-mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1074
evil-with-undo:
nconc'ing onto front of buffer-undo-list here can corrupt buffer-undo-list
when in undo-tree-mode in rare circumstances (see issue Remove undo-tree dependency #1074 referenced
above). Since evil-temporary-undo was always nil when executing @Body
anyway, and reset to nil at end, other elisp code could never see a non-nil
value for it anyway here. So we fix the nconc bug by simplifying the code,
and getting rid of the redundant evil-temporary-undo juggling in the
process.
evil-undo-pop:
This function called `undo' directly from Elisp, which is almost always a bug
in undo-tree-mode. Fix this by calling undo-tree-undo instead when in
undo-tree-mode.