Fix term-mode undo issue #914

toctan · 2017-09-01T03:22:24Z

Currently Evil breaks term-char-mode undo by enabling undo-tree-mode, see
syl20bnr/spacemacs#4063 (comment)

turn-on-undo-tree-mode checks the variable undo-tree-incompatible-major-modes
before enabling undo-tree-mode, see https://github.com/emacs-evil/evil/blob/master/lib/undo-tree.el#L2618

Currently Evil breaks `term-char-mode` undo by enabling `undo-tree-mode`, see syl20bnr/spacemacs#4063 (comment) `turn-on-undo-tree-mode` checks the variable `undo-tree-incompatible-major-modes` before enabling `undo-tree-mode`, see https://github.com/emacs-evil/evil/blob/master/lib/undo-tree.el#L2618

wasamasa · 2017-09-01T18:31:03Z

Hm, I don't exactly see a change in behavior with and without this PR, but I agree that undo-tree-mode shouldn't be enabled in ansi-term. Thanks!

toctan · 2017-09-03T07:05:55Z

@wasamasa Try use C-_ instead of C-/ in ansi-term to undo with & without this PR.

wasamasa merged commit e745d56 into emacs-evil:master Sep 1, 2017

Provide feedback