Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer over TRAMP hangs #3020

Closed
2 of 3 tasks
hchencs opened this issue Jul 26, 2021 · 4 comments · Fixed by #4204
Closed
2 of 3 tasks

rust-analyzer over TRAMP hangs #3020

hchencs opened this issue Jul 26, 2021 · 4 comments · Fixed by #4204
Labels

Comments

@hchencs
Copy link

hchencs commented Jul 26, 2021

Thank you for the bug report

  • I am using the latest version of lsp-mode related packages.
  • I checked FAQ and Troubleshooting sections
  • You may also try reproduce the issue using clean environment using the following command
emacs -q -l lsp-start-plain.el

where lsp-start-plain.el can be downloaded here.

Bug description

Emacs hangs when I opened a Rust source file via TRAMP over SSH.

  • Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 2.24.32, cairo version 1.16.0)
  • lsp-mode 20210724.1836
  • tramp 2.5.1
  • rust-analyzer ea105f9 2021-07-25 dev

On the server, /tmp/rust-analyzer-remote-1-stderr is empty.

lsp-log.txt

Steps to reproduce

emacs -q -l .emacs-test.txt /ssh:server:path/to/file
.emacs-test.txt

Expected behavior

Emacs should not hang.

Which Language Server did you use?

rust-analyzer ea105f9 2021-07-25 dev

OS

Linux

Error callstack

`lsp-log.txt` was attached above.

Anything else?

No response

@hchencs hchencs added the bug label Jul 26, 2021
@yyoncho
Copy link
Member

yyoncho commented Jul 26, 2021

Does it go away after C-g or multiple C-g?

@hchencs
Copy link
Author

hchencs commented Jul 26, 2021

Does it go away after C-g or multiple C-g?

It went away only after multiple C-g. After that, no connection with the server exists.

@hchencs
Copy link
Author

hchencs commented Jul 26, 2021

Also I am using GccEmacs.

@brotzeit
Copy link
Member

The issue is that tramp doesn't try to reconnect automatically right brotzeit/rustic#361 (comment) ?

yyoncho added a commit to yyoncho/lsp-mode that referenced this issue Oct 27, 2023
- This fixes the implementation of `lsp-mode` tramp support. After this PR the
remote clients will be automatically registered and in most of the cases it will
work out of the box. The remote connection is managed to a way similar to what
eglot does.

Fixes emacs-lsp#4158
Fixes emacs-lsp#4150
Fixes emacs-lsp#4158
Fixes emacs-lsp#4150
Fixes emacs-lsp#3841
Fixes emacs-lsp#3642
Fixes emacs-lsp#3579
Fixes emacs-lsp#3530
Fixes emacs-lsp#3491
Fixes emacs-lsp#3490
Fixes emacs-lsp#3391
Fixes emacs-lsp#3369
Fixes emacs-lsp#3364
Fixes emacs-lsp#3020
Fixes emacs-lsp#3018
Fixes emacs-lsp#3020
yyoncho added a commit to yyoncho/lsp-mode that referenced this issue Oct 30, 2023
- This fixes the implementation of `lsp-mode` tramp support. After this PR the
remote clients will be automatically registered and in most of the cases it will
work out of the box. The remote connection is managed to a way similar to what
eglot does.

Fixes emacs-lsp#4158
Fixes emacs-lsp#4150
Fixes emacs-lsp#4158
Fixes emacs-lsp#4150
Fixes emacs-lsp#3841
Fixes emacs-lsp#3642
Fixes emacs-lsp#3579
Fixes emacs-lsp#3530
Fixes emacs-lsp#3491
Fixes emacs-lsp#3490
Fixes emacs-lsp#3391
Fixes emacs-lsp#3369
Fixes emacs-lsp#3364
Fixes emacs-lsp#3020
Fixes emacs-lsp#3018
Fixes emacs-lsp#3020
@yyoncho yyoncho closed this as completed in d45aca0 Nov 1, 2023
yyoncho added a commit to yyoncho/lsp-mode that referenced this issue Nov 2, 2023
* Fix lsp-mode's tramp support

- This fixes the implementation of `lsp-mode` tramp support. After this PR the
remote clients will be automatically registered and in most of the cases it will
work out of the box. The remote connection is managed to a way similar to what
eglot does.

Fixes emacs-lsp#4158
Fixes emacs-lsp#4150
Fixes emacs-lsp#4158
Fixes emacs-lsp#4150
Fixes emacs-lsp#3841
Fixes emacs-lsp#3642
Fixes emacs-lsp#3579
Fixes emacs-lsp#3530
Fixes emacs-lsp#3491
Fixes emacs-lsp#3490
Fixes emacs-lsp#3391
Fixes emacs-lsp#3369
Fixes emacs-lsp#3364
Fixes emacs-lsp#3020
Fixes emacs-lsp#3018
Fixes emacs-lsp#3020

* Use executable-find with remote = t everywhere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants