Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(🎁) Support basedpyright #92

Closed
KotlinIsland opened this issue Mar 29, 2024 · 5 comments
Closed

(🎁) Support basedpyright #92

KotlinIsland opened this issue Mar 29, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@KotlinIsland
Copy link

Basedpyright is a Pyright fork with many improvements and new features

Link: https://github.com/DetachHead/basedpyright

I would be awesome if this project could support Basedpyright

@zipy124
Copy link
Contributor

zipy124 commented Aug 25, 2024

Basedpyright is a Pyright fork with many improvements and new features

Link: https://github.com/DetachHead/basedpyright

I would be awesome if this project could support Basedpyright

I've added a pull request to merge support, which could be enabled by using customize on the lsp-pyright-fork command to change from "pyright" to "basedpyright". In the meantime if you want to use it you can change your recipe to point to https://github.com/zipy124/lsp-basedpyright .

@seagle0128
Copy link
Collaborator

Thanks to @zipy124 . We are working on the PR #101.

@seagle0128 seagle0128 added the enhancement New feature or request label Aug 25, 2024
@JohnDevlopment
Copy link

I tried using it but I got this error: Unable to find installed server supporting this file. The following servers could be installed automatically:

Previously, I had been using pyright, but I recently changed the option to use basedpyright, hence this error.

@seagle0128
Copy link
Collaborator

@JohnDevlopment You need to install basedpyright manually. See https://docs.basedpyright.com/#/installation.

@rirze
Copy link

rirze commented Sep 30, 2024

I didn't see any documentation covering this, so I'm leaving a snippet for anyone figuring this out like I did:

(use-package lsp-pyright
  :ensure t
  :custom
  (lsp-pyright-langserver-command "basedpyright")
  :hook (python-base-mode . (lambda ()
                              (require 'lsp-pyright)
                              (lsp))))  ; or lsp-deferred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants