-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for the basedpyright pyright fork #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, except lsp-pyright-fork
option. I am afraid it's confusing.
And, are all options and arguments of pyright
and basedpyright
just same?
I merged and changed |
Thank you for the quick review, changes and merge!
Of the options provided by this module they are all the same (I think). I have unfortunately run into the fact that the options are not all the same for the full list, for example: python.analysis.typeCheckingMode vs basedpyright.analysis.typeCheckingMode and further confusing matters: basedpyright.analysis.useLibraryCodeForTypes vs python.analysis.useLibraryCodeForTypes or pyright.useLibraryCodeForTypes . I'm unsure what the best option is here between the available options:
|
Well, it's better keep the common configurations and leave the rest to the json file, IMO. |
emacs-lsp/lsp-pyright@cc6df06aeaee -> emacs-lsp/lsp-pyright@0c0d72aedd18 necaris/conda.el@60e14d1e9793 -> necaris/conda.el@ce748a53f9c7 pythonic-emacs/anaconda-mode@79fa9b4d2bda -> pythonic-emacs/anaconda-mode@f900bd7656a0 pythonic-emacs/company-anaconda@1fe526163c26 -> pythonic-emacs/company-anaconda@169252fca79a pythonic-emacs/pyenv-mode@de0d750b9c30 -> pythonic-emacs/pyenv-mode@76787ea44f63 wbolster/emacs-python-pytest@9f850e22df93 -> wbolster/emacs-python-pytest@dcdaec6fe203 - Adds basedpyright support to lsp-pyright; and will prioritize it above pyright, if found on your system. Ref: emacs-lsp/lsp-pyright#101
This PR addresses issue: #92
All commands that use "pyright/" are now instead created via concatenating the fork with the command. This can be customised with the lsp-pyright-fork customizable option.
use of "backquote" command instead of " ' " is because of an emacs-lisp bug please see: https://stackoverflow.com/questions/17394638/nesting-backquote-and-in-emacs-lisp and https://mail.gnu.org/archive/html/bug-gnu-emacs/2023-02/msg00617.html
All suggestions welcome, this is my first time contributing emacs-lisp code so I am not well versed with the standard practices :)