Allow setting driver options via a customizable variable #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a customizable variable for driver options (such as linker flags) to pass to libgccjit (Bug #42761). * lisp/emacs-lisp/comp.el (comp-native-driver-options): New customization variable. * src/comp.c: Use comp-native-driver-options to set libgccjit's driver options, if supported on the library's ABI version.
Ensure the variable is set to the value that was customized in the parent process in child compilation processes, also.
Otherwise, this would break async compilation with a merely semi-visible error message.
* Instead of conditionalizing on the wrong preprocessor flag, now use the right one: LIBGCCJIT_HAVE_gcc_jit_context_add_driver_option * Also perform the driver-option-adding step on win NT, but only if the function is non-NULL. * Make the function declaration for add_driver_options non-old-style.
|
Emacs does not use GitHub; this is just a mirror. To get your patch noticed, please send it to bug-gnu-emacs@gnu.org with a summary of your changes. You could create a patch using the command 'git format-patch -1' and attach the resulting file to your email. |
Resolves merge conflict in comp.el
|
Yep, feel free to close this PR - I'm using this entry only as a reference point to push my branch / reference it in a nixpkgs/emacs-overlay patch for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=42761. |
flatwhatson
pushed a commit
to flatwhatson/emacs
that referenced
this pull request
Nov 23, 2020
implement popup menu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses GNU Emacs
bug#42761, adding a variable for passing driver options to libgccjit.Those are necessary for Darwin at least, where the linker does not understand the
LINKER_FLAGSenvironment variable.Inclusion of this patch is pending copyright assignment paperwork (in progress!)