Circular dependencies #4 #5
Conversation
- Remove test duplication
- Move definitions and relations parsing into parse method - Test app from Data class rather than File class - Add example circular file to test
| @@ -0,0 +1,11 @@ | |||
| RSpec.configure do |config| | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
| @@ -0,0 +1,5 @@ | |||
| class ModuleWithOneClassDependency | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
| @@ -0,0 +1,2 @@ | |||
| module ModuleWithNoRelations | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
| @@ -0,0 +1,15 @@ | |||
| class A | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
| @@ -0,0 +1,3 @@ | |||
| class ClassWithOneIncludedMixin | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
| @@ -4,6 +4,10 @@ d3.json("/data.json", function(error, data) { | |||
| $('.toolbox').show(); | |||
| }); | |||
|
|
|||
| var classForCircular = function(d) { | |||
| return d.circular ? 'circular' : ''; | |||
| } | |||
| end | ||
|
|
||
| private | ||
|
|
||
| class Graph < Hash |
There was a problem hiding this comment.
Missing top-level class documentation comment.
| def self.do; end | ||
| end | ||
|
|
||
| class C |
There was a problem hiding this comment.
Missing top-level class documentation comment.
| def self.do; end | ||
| end | ||
|
|
||
| class B |
There was a problem hiding this comment.
Missing top-level class documentation comment.
| @@ -0,0 +1,23 @@ | |||
| class A | |||
There was a problem hiding this comment.
Missing top-level class documentation comment.
Missing magic comment # frozen_string_literal: true.
|
1 violation remaining, can't for the life of me find how to view the violation. |
In this branch I have done the following:
Added basic test coverage through the Data class using RSpec
Implemented the feature
Added example file in lib to test behavior.
I am happy to discuss switching to another testing framework if you prefer, I simply chose what I am most comfortable with. Also, I am hoping for a better way to test the app then pollute it with the test classes.
Fixes #4