Skip to content

Commit

Permalink
--enable-new-dtags
Browse files Browse the repository at this point in the history 
Linuxbrew#598
disclaimer: i have no idea what i'm doing
  • Loading branch information
@emanresusername
emanresusername committed Feb 10, 2018
1 parent 8ccb999 commit 48c763c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Library/Homebrew/shims/linux/super/cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ class Cmd
args += ["#{wl}--dynamic-linker=#{dynamic_linker_path}"] if dynamic_linker_path
args << "-B#{@opt}/glibc/lib" unless mode == :ld
args += path_flags("-L", library_paths)
args += rpath_flags("#{wl}-rpath=", rpath_paths)
args += rpath_flags("#{wl}--enable-new-dtags,-rpath=", rpath_paths)
end
def isystem_paths
Expand Down

6 comments on commit 48c763c

@bukzor
Copy link

@bukzor bukzor commented on 48c763c Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this work whatsoever?

@emanresusername
Copy link
Owner Author

@emanresusername emanresusername commented on 48c763c Feb 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bukzor unfortunately no 😢
i tried using a different install script that pointed to this and that threw some errors that i don't remember but didn't seem related to this change
then just tried the normal install and modifying this file afterwards in termux... still no luck

@sjackman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch should work. I can't say off the top of my head why it doesn't. Please comment in issue Linuxbrew#598 and report the output of…

brew install -s hello
brew gist-logs hello

@sjackman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that the implicit brew update hasn't undone your change.

@emanresusername
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if my understanding is correct, this comment (and the following convo) are saying this'd be futile without a core termux change?

@sjackman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not futile. RPATH doesn't work on Android, but RUNPATH does. The instruction --enable-new-dtags instructs ld to use RUNPATH rather than the default RPATH. RUNPATH is supported on Android 7+.

Please sign in to comment.