test(stack/storage): updates dependencies and add missing tests #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode's analysis on #9fd345 found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
jrainville
reviewed
Mar 2, 2020
packages/stack/storage/package.json
Outdated
| "embark-solo": "^5.2.3", | ||
| "embark-utils": "^5.3.0-nightly.0", |
There was a problem hiding this comment.
You put embark-utils both in dependencies and dev-deps, you can remove the latter then.
0x-r4bbit
force-pushed
the
test/stack/storage
branch
from
6d796f4 to
7215d0e
Compare
michaelsbradleyjr
suggested changes
Mar 4, 2020
0x-r4bbit
force-pushed
the
test/stack/storage
branch
2 times, most recently
from
b84ee38 to
c7c533e
Compare
|
Thanks @jrainville and @michaelsbradleyjr for you comments. This is now updated accordingly and rebased on top of latest master |
0x-r4bbit
force-pushed
the
test/stack/storage
branch
from
c7c533e to
9d620bd
Compare
michaelsbradleyjr
approved these changes
Mar 5, 2020
|
Needs a rebase. |
0x-r4bbit
force-pushed
the
test/stack/storage
branch
from
9d620bd to
4eed997
Compare
0x-r4bbit
force-pushed
the
test/stack/storage
branch
from
4eed997 to
9fd3456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.