Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Atomic type polyfill #6

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Atomic type polyfill #6

merged 4 commits into from
Sep 24, 2021

Conversation

MabezDev
Copy link
Contributor

@MabezDev MabezDev commented Sep 22, 2021

Add support for riscv critical sections too.

@bjoernQ
Copy link

bjoernQ commented Sep 24, 2021

I was about to submit a similar PR but would love to also have riscv32imfc and riscv32i covered
But also, haven't tested this yet

@MabezDev
Copy link
Contributor Author

I was about to submit a similar PR but would love to also have riscv32imfc and riscv32i covered

Latest commit should cover the other targets :)

@MabezDev
Copy link
Contributor Author

Tested and working on a esp32c3, ready for review!

@bjoernQ
Copy link

bjoernQ commented Sep 24, 2021

also tested it on BL602 - works fine 👍

Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you! :)

@Dirbaio Dirbaio merged commit e60bbf4 into embassy-rs:main Sep 24, 2021
@Dirbaio
Copy link
Member

Dirbaio commented Sep 24, 2021

I'm going to refactor a bit to get rid of the "Deref" hack (I've never liked it, but now that we can polyfill the entire types from scratch it makes even less sense), then I'll release 0.1.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants