Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rp-rs copyright notice #3261

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

thejpster
Copy link
Contributor

Updates LICENSE-MIT and some source files to indicate the copyright holder.

The first commit is as required by the MIT license. The second I thought would be useful, but isn't strictly required.

@jamesmunns jamesmunns enabled auto-merge August 16, 2024 14:26
@jamesmunns jamesmunns added this pull request to the merge queue Aug 16, 2024
@Dirbaio Dirbaio removed this pull request from the merge queue due to a manual request Aug 16, 2024
LICENSE-MIT Outdated
@@ -1,4 +1,5 @@
Copyright (c) Embassy project contributors
Copyright (c) rp-rs organization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't apply to the entire repo. Would you consider the copyright line in the .rs files enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you give someone a copy of the software, you need to include the license text and any copyright notice (https://writing.kemitchell.com/2016/09/21/MIT-License-Line-by-Line.html)

Just including the copyright notice in the source files, along with the note that it is MIT licensed, is probably sufficient for source based releases. I don't know the details of how you manage licences in binary releases (or how/if you encourage your users to manage those licenses in their binary releases), but it would be typical to encourage distributors to take a copy of any top-level LICENSE* and NOTICE* files and to redistribute those along with the binary, and in that case, the copyright notices in the source files would be lost. Perhaps a copy of the LICENSE-MIT file at the top-level of every HAL is a reasonable compromise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should also note that the Rust Project is Quite Bad at this currently. It's a work in progress.

Copy link
Member

@Dirbaio Dirbaio Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that's a very good point. LICENSE* files at the root seem to be the de-facto standard, copyright lines in loose .rs files won't get picked up by people writing scripts that collect *LICENSE* files like yours for their binary releases.

let's add LICENSE files to embassy-rp then.

thejpster and others added 2 commits August 16, 2024 17:48
@Dirbaio Dirbaio force-pushed the update-rp-rs-copyright branch from c85449f to 16c3e58 Compare August 16, 2024 15:52
@Dirbaio Dirbaio added this pull request to the merge queue Aug 16, 2024
Merged via the queue into embassy-rs:main with commit 6d9ed4c Aug 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants