RP2040/235x: Add I2C bus lockup detection and async recovery implementation. #4908
+121
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computer-whisperer
force-pushed
the
i2c-fix-master
branch
from
41f24ac to
55f5e4f
Compare
CBJamo
reviewed
Jan 10, 2026
Comment on lines
+525
to
+532
| if !ignore_lockup { | ||
| if self.is_sda_low() { | ||
| return Err(Error::SDAHeldLow); | ||
| } | ||
| if self.is_scl_low() { | ||
| return Err(Error::SCLHeldLow); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
What's the use case for this/why would you ever want to ignore a locked bus?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various possibilities for bus-lock exist with the rp2040 and rp2350 i2c peripherals. The synopsis i2c peripheral is not included with the bus-clear option, meaning detection and recovery has to be implemented in software.
This change adds detection of these conditions to both blocking and async usage, and bit-banged automatic recovery for the async variants.