Switch to Dead phase if LCP gets terminated by the peer.

embassy-rs · Aug 29, 2023 · e5dc10a · e5dc10a
1 parent 8667375
commit e5dc10a
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/ppp/mod.rs b/src/ppp/mod.rs
@@ -47,6 +47,7 @@ pub struct Status {
 
 pub(crate) struct PPP<'a> {
     phase: Phase,
+    opening: bool,
     pub(crate) lcp: OptionFsm<LCP>,
     pub(crate) pap: PAP<'a>,
     pub(crate) ipv4cp: OptionFsm<IPv4CP>,
@@ -56,6 +57,7 @@ impl<'a> PPP<'a> {
     pub fn new(config: Config<'a>) -> Self {
         Self {
             phase: Phase::Dead,
+            opening: false,
             lcp: OptionFsm::new(LCP::new()),
             pap: PAP::new(config.username, config.password),
             ipv4cp: OptionFsm::new(IPv4CP::new()),
@@ -77,6 +79,7 @@ impl<'a> PPP<'a> {
         match self.phase {
             Phase::Dead => {
                 self.phase = Phase::Establish;
+                self.opening = true;
                 Ok(())
             }
             _ => Err(crate::InvalidStateError),
@@ -104,6 +107,7 @@ impl<'a> PPP<'a> {
             Phase::Establish => {
                 if self.lcp.state() == State::Closed {
                     tx(self.lcp.open());
+                    self.opening = false;
                 }
 
                 if self.lcp.state() == State::Opened {
@@ -144,6 +148,10 @@ impl<'a> PPP<'a> {
             Phase::Open => {}
         }
 
+        if self.lcp.state() == State::Closed && !self.opening {
+            self.phase = Phase::Dead
+        }
+
         if old_phase != self.phase {
             info!("PPP link phase {:?} -> {:?}", old_phase, self.phase);
         }