Consolidate UUID from slice functionality into TryFrom implementation #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petekubiak
requested review from
lulf and
jamessizeland
and removed request for
lulf
|
/test |
|
FYI, there are also (rarely used) 32-bit Bluetooth UUIDs. |
jamessizeland
approved these changes
Jan 14, 2025
Worth adding an issue for? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on making get and set generic for all attributes (#155) I noticed there were multiple "from slice" implementations for the Uuid type, which would panic if the slice length didn't match what was expected.
I've consolidated these with a single TryFrom implementation instead.