Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl does not recognize protocol FTPES #25

Closed
quarcko opened this issue Apr 30, 2021 · 2 comments
Closed

libcurl does not recognize protocol FTPES #25

quarcko opened this issue Apr 30, 2021 · 2 comments

Comments

@quarcko
Copy link
Contributor

quarcko commented Apr 30, 2021

Hi,

Maybe it is my system problem, but on ubuntu 16.04 with
libcurl4-gnutls-dev (7.47.0-1ubuntu2.19)
it fails to connect with FTPES type of server throwing an error:
"[FTPClient][Error] Unable to connect to remote folder / (Error = 1 | Unsupported protocol)."

But there is a fix for this, when connecting to FTPES server, you don't need to specify "ftpes://"
but just a regular "ftp://" instead.

change on line 206:
case FTP_PROTOCOL::FTPES: strURL = "ftp://" + strURL; //libcurl does not recognize 'ftpes' it should be just 'ftp'! break;

@embeddedmz
Copy link
Owner

Hi @quarcko,

I unit tested FTP and SFTP but still didn't test FTPS or FTPES (I added Issue #23 to test them, I will unit test FTPS with Cerberus FTP Server 11 or maybe FileZilla Server too).

So you can do this (remove the FTPES case before and add the FTPES case below the FTP one) and send a pull request I will merge it :

         case FTP_PROTOCOL::FTP:
         case FTP_PROTOCOL::FTPES:
         default:
            strURL = "ftp://" + strURL;
            break;

Thanks.

@quarcko
Copy link
Contributor Author

quarcko commented Apr 30, 2021

Created pull request:
#28

closing.

@quarcko quarcko closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants