Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Merge main #2324

Merged
merged 15 commits into from
Mar 11, 2025
Merged

[v2] Merge main #2324

merged 15 commits into from
Mar 11, 2025

Conversation

Samoed
Copy link
Collaborator

@Samoed Samoed commented Mar 11, 2025

Code Quality

  • Code Formatted: Format the code using make lint to maintain consistent style.

Documentation

  • Updated Documentation: Add or update documentation to reflect the changes introduced in this PR.

Testing

  • New Tests Added: Write tests to cover new functionality. Validate with make test-with-coverage.
  • Tests Passed: Run tests locally using make test or make test-with-coverage to ensure no existing functionality is broken.

Adding datasets checklist

Reason for dataset addition: ...

  • I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.
    • sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2
    • intfloat/multilingual-e5-small
  • I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
  • If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
  • I have filled out the metadata object in the dataset file (find documentation on it here).
  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

Adding a model checklist

  • I have filled out the ModelMeta object to the extent possible
  • I have ensured that my model can be loaded using
    • mteb.get_model(model_name, revision) and
    • mteb.get_model_meta(model_name, revision)
  • I have tested the implementation works on a representative set of tasks.

github-actions and others added 14 commits March 8, 2025 18:42
Automatically generated by python-semantic-release
* Added Filter Modality

* resolve suggestions

* make lint

* make sure test pass

* make lint

* added exclusive_modality_filter and unit tests

* Integrate tests on overview.py

* Update tests/test_overview.py

Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>

* added task related to image modality

* Update mteb/abstasks/AbsTask.py

Co-authored-by: Kenneth Enevoldsen <kennethcenevoldsen@gmail.com>

* Update mteb/abstasks/AbsTask.py

Co-authored-by: Kenneth Enevoldsen <kennethcenevoldsen@gmail.com>

* update overview..py

* make lint

* update documentation

---------

Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
Co-authored-by: Kenneth Enevoldsen <kennethcenevoldsen@gmail.com>
Automatically generated by python-semantic-release
* license validation

* move licenses

* update imports

---------

Co-authored-by: Isaac Chung <chungisaac1217@gmail.com>
Automatically generated by python-semantic-release
* make dev life nicer - pre-commit hooks

* add pre-commit to install

* update precommit

* update ruff pre-commit

* lint

* lint

---------

Co-authored-by: sam021313 <40773225+sam021313@users.noreply.github.com>
* fix: Fix bug in voyage implementation

"passage" is not a valid input for the voyage API. Remapped to "document".

* Update mteb/models/voyage_models.py

Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>

---------

Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
Automatically generated by python-semantic-release
Automatically generated by python-semantic-release
* Added VDR Model

* change custom wrapper to SentenceTransformer Wrapper

* remove kwargs and add TODO for Image Modality

* Update mteb/models/vdr_models.py

Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>

---------

Co-authored-by: Roman Solomatin <samoed.roman@gmail.com>
# Conflicts:
#	CONTRIBUTING.md
#	Makefile
#	README.md
#	mteb/abstasks/TaskMetadata.py
#	mteb/descriptive_stats/InstructionRetrieval/Core17InstructionRetrieval.json
#	mteb/descriptive_stats/Retrieval/mFollowIRCrossLingualInstructionRetrieval.json
#	mteb/descriptive_stats/Retrieval/mFollowIRInstructionRetrieval.json
#	mteb/models/voyage_models.py
#	mteb/tasks/Classification/tur/__init__.py
#	mteb/tasks/PairClassification/deu/__init__.py
#	mteb/tasks/Retrieval/eng/NQRetrieval.py
#	mteb/tasks/Retrieval/eng/NanoNQRetrieval.py
#	pyproject.toml
#	tests/test_overview.py
@Samoed Samoed changed the base branch from main to v2.0.0 March 11, 2025 10:39
@Samoed Samoed merged commit 1447a76 into v2.0.0 Mar 11, 2025
9 checks passed
@Samoed Samoed deleted the merge_main branch March 11, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants