Allow wrapping the default reporter without having to rebuild it #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acorncom
force-pushed
the
export-default-reporter
branch
from
ae99c61
to
ebe0389
Compare
acorncom
force-pushed
the
export-default-reporter
branch
from
ebe0389
to
06ff2bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently expose
_TEST_SUITE_RESULTSand_middlewareReporterto allow customizing reporting without needing to build the entire set of reporting / middleware / test violation capture. But we don't currently allow wrapping the default reporter which hampers any ability to filter violation results (or report on them differently) while still using the core setup within default reporter.It's probably worth thinking through ways to expose all of these items as "wrappable" more easily, but short-term I'm working on an app that could use the ability to filter results in certain scenarios