Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail in the quickstart guide for setup with ember-cli-deploy-redis #5

Merged
merged 1 commit into from
Jan 6, 2016

Conversation

g-cassie
Copy link
Contributor

@g-cassie g-cassie commented Dec 8, 2015

Please feel free to edit. This took me a little a bit of poking around the ember-cli-deploy docs and examples to figure out for myself so I think it could save some time for the next person.

@ghedamat
Copy link
Collaborator

ghedamat commented Dec 9, 2015

thanks for this @g-cassie
This has very good timing with ember-cli-deploy/ember-cli-deploy-redis#38

It would be great if you could rework this PR a bit to better explain how ssh-tunnel can now work with the redis plugin

@ghedamat
Copy link
Collaborator

ghedamat commented Dec 9, 2015

also mind prefixing your commit with [DOC]

thanks!

@g-cassie
Copy link
Contributor Author

g-cassie commented Dec 9, 2015

Ok, looks like those changes should make the config work out of the box. Once a release is cut with ember-cli-deploy/ember-cli-deploy-redis#38 I will revise my comments and add a reference to the minimum version number for ember-cli-redis that is needed for the auto config to work.

@ghedamat
Copy link
Collaborator

@g-cassie perfect, I'll ping you when we release the other plugin, just waiting to merge a couple of PRs

@ghedamat
Copy link
Collaborator

@g-cassie ok, just released 0.1.1 of ember-cli-deploy-redis

@ghedamat
Copy link
Collaborator

ghedamat commented Jan 5, 2016

@g-cassie ping in case you have a sec to finish this

@g-cassie
Copy link
Contributor Author

g-cassie commented Jan 5, 2016

@ghedamat Thanks - I just pushed a rebased commit. It seems that this basically works right out of the box now so I basically am just providing some background on how it works. Let me know if you want me to make any changes.

Sorry for the delay!

@ghedamat
Copy link
Collaborator

ghedamat commented Jan 6, 2016

Thank you!

ghedamat added a commit that referenced this pull request Jan 6, 2016
Add more detail in the quickstart guide for setup with ember-cli-deploy-redis
@ghedamat ghedamat merged commit ca4aa93 into ember-cli-deploy:master Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants