Make the regex less permissive #67
Open
+47
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rickharrison ping |
|
Are there other members on the ember team that would be interested in helping to maintain this package? |
|
@rickharrison my understanding is that some would like to see it rewritten to use an actual syntax aware parser instead of regexes, but that it hasn't yet been a high enough priority for anyone to put in the leg work. |
|
@rwjblue thoughts? |
|
This fixes #20 |
wagenet
force-pushed
the
less-permissive-regex
branch
from
48a9735 to
22e1b6c
Compare
wagenet
force-pushed
the
less-permissive-regex
branch
from
22e1b6c to
5918b95
Compare
|
@rwjblue I've updated this for v3. Though ultimately I'd love to see this back ported to v2 or have broccoli-asset-rev updated to work with v3 also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.